Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 )
Change subject: IMPALA-7941: part 2/2: use cgroups memory limit ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/12262/3/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/12262/3/be/src/runtime/exec-env.cc@357 PS3, Line 357: ot nit: to http://gerrit.cloudera.org:8080/#/c/12262/3/be/src/runtime/exec-env.cc@405 PS3, Line 405: --mem_limit=" : << PrettyPrinter::PrintBytes(*bytes_limit); this log line can be confusing to mean that the --mem_limit was set to bytes_limit. eg. --mem_limit=10GB, avail_mem = 7GB, so bytes_limit will be 7GB but the log line will say: "Using process memory limit from --mem_limit=7GB" -- To view, visit http://gerrit.cloudera.org:8080/12262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9fb4fb936a46fc194a204391d03c07c8c7fba21 Gerrit-Change-Number: 12262 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 25 Jan 2019 21:09:40 +0000 Gerrit-HasComments: Yes
