Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 )
Change subject: IMPALA-7694: Add host resource usage metrics to profile ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/12069/11/tests/observability/test_plot_profile_resource_usage.py File tests/observability/test_plot_profile_resource_usage.py: http://gerrit.cloudera.org:8080/#/c/12069/11/tests/observability/test_plot_profile_resource_usage.py@35 PS11, Line 35: thrift_profile = self.impalad_test_service.get_compressed_thrift_profile( > I didn't know about the HS2 api, that's something that we should make use o I kind-of think we should just fix it. self.hs2_client should already be a ImpylaHS2Connection client that exposes a reasonably high-level interface. Something like below would work if you plumbed through the profile option to the HS2 interface. self.hs2_client.set_configuration_option() handle = self.hs2_client.execute_async(..) self.hs2_client.fetch(handle) thrift_profile = self.hs2_client.get_profile(format=...) self.hs2_client.close_query(handle) Or actually the profile format could reasonably be an argument to execute(), since it's already fetching the profile anyway. -- To view, visit http://gerrit.cloudera.org:8080/12069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aedc20c553ab8d7ed50f72a1a936eba151487d9 Gerrit-Change-Number: 12069 Gerrit-PatchSet: 11 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 01:15:52 +0000 Gerrit-HasComments: Yes
