Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 )
Change subject: IMPALA-7694: Add host resource usage metrics to profile ...................................................................... Patch Set 13: (3 comments) Thanks for the review, please see my inline comments and PS14 http://gerrit.cloudera.org:8080/#/c/12069/13/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/12069/13/be/src/runtime/coordinator.cc@789 PS13, Line 789: // TODO: Move to host profiles? > This seems like the right thing to do. Maybe file a JIRA to track? We could Filed IMPALA-8126 http://gerrit.cloudera.org:8080/#/c/12069/13/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/12069/13/be/src/runtime/query-state.cc@151 PS13, Line 151: CpuUserPercentage > Should we add a System prefix to these or similar? Otherwise it could be in How about Host* or Node*? With Sys we have something like SysCpuSysPercentage or SystemCpuSysPercentage. I picked one but am happy to change it to something else, too. http://gerrit.cloudera.org:8080/#/c/12069/11/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/12069/11/be/src/util/runtime-profile.h@419 PS11, Line 419: Samples : /// are not re-sampled into larger intervals, instead owners of this profile can call : /// ClearChunkedTimeSeriesCounters() to reset the sample buffers of all chunked time : /// series counters > I hadn't thought about this, but I think it's worth doing, just so that we Done -- To view, visit http://gerrit.cloudera.org:8080/12069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aedc20c553ab8d7ed50f72a1a936eba151487d9 Gerrit-Change-Number: 12069 Gerrit-PatchSet: 13 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 26 Jan 2019 02:45:37 +0000 Gerrit-HasComments: Yes
