Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 )
Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Small comment on the commit message, but looks good. Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/12288/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12288/1//COMMIT_MSG@9 PS1, Line 9: Running against S3 and erasure coded HDFS causes slight changes in the : observed ExchangeScanRatio and breaks such downstream tests. This change : limits the affected test to HDFS local minicluster runs without EC. Nit: Can you mention the test that you are skipping? Also, one can run this test on S3 or erasure coded HDFS using only the Apache repo, so it would be good to remove the reference to downstream. -- To view, visit http://gerrit.cloudera.org:8080/12288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb Gerrit-Change-Number: 12288 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 19:40:02 +0000 Gerrit-HasComments: Yes
