Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 )
Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12288/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12288/4/tests/query_test/test_observability.py@396 PS4, Line 396: @SkipIfNotHdfsMinicluster.tuned_for_minicluster > Nit: This is triple conditional is hard to read. Skip if it is not an HDFS Just saw this comment, apologies for missing it during the initial round of reviews. I agree, these are somewhat hard to decipher, but I found over time they become more clear, and it's consistent with what we usually do. Maybe you can think of ways to make them more readable in general? -- To view, visit http://gerrit.cloudera.org:8080/12288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb Gerrit-Change-Number: 12288 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Sat, 02 Feb 2019 06:53:43 +0000 Gerrit-HasComments: Yes
