Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12292 )

Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges
......................................................................


Patch Set 1:

I'm currently working on moving forward branch-2.x. For the first patch, 
"0b540b025 IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, 
Partition", the cherry-pick conflicts is due to the revert of IMPALA-6479 in 
2.x. So here we backport IMPALA-6479 again.

It's a clean cherry-pick but fail some tests. Applied following changes to fix 
the tests.

diff --git a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java 
b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
index 5a953ad..933ead7 100644
--- a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
+++ b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
@@ -1860,6 +1860,7 @@ public class AuthorizationTest extends FrontendTestBase {
       "","NULL","NULL",
       "# Detailed Table Information","NULL","NULL",
       "Database:","functional","NULL",
+      "OwnerType:","USER","NULL",
       "Owner:","*","NULL",
       "CreateTime:","*","NULL",
       "LastAccessTime:","UNKNOWN","NULL",
@@ -1871,6 +1872,7 @@ public class AuthorizationTest extends FrontendTestBase {
       "","DO_NOT_UPDATE_STATS","true",
       "","EXTERNAL","TRUE",
       "","STATS_GENERATED_VIA_STATS_TASK","true",
+      "","impala.lastComputeStatsTime","*",
       "","numRows","11000",
       "","totalSize","834279",
       "","transient_lastDdlTime","*",
@@ -1905,6 +1907,7 @@ public class AuthorizationTest extends FrontendTestBase {
       "","NULL","NULL",
       "# Detailed Table Information","NULL","NULL",
       "Database:","functional","NULL",
+      "OwnerType:","USER","NULL",
       "Owner:","*","NULL",
       "CreateTime:","*","NULL",
       "LastAccessTime:","UNKNOWN","NULL",
@@ -1915,6 +1918,7 @@ public class AuthorizationTest extends FrontendTestBase {
       "","DO_NOT_UPDATE_STATS","true",
       "","EXTERNAL","TRUE",
       "","STATS_GENERATED_VIA_STATS_TASK","true",
+      "","impala.lastComputeStatsTime","*",
       "","numRows","100",
       "","totalSize","6472",
       "","transient_lastDdlTime","*",


--
To view, visit http://gerrit.cloudera.org:8080/12292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Adam Holley <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 29 Jan 2019 07:21:36 +0000
Gerrit-HasComments: No

Reply via email to