Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12292 )
Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges ...................................................................... Patch Set 1: (2 comments) > Patch Set 1: Code-Review-1 > > This is a compatibility breaking fix for 2.x. Unless there is a strong case, > I'd prefer not to merge this as is. Thoughts? This is picked in CDH branch too: https://github.com/cloudera/Impala/commit/f8a318d4f75e22a963b9cf4786ef07d2cd6bd93c Is it really a compatibility breaking fix for 2.x? I'm going to pick https://gerrit.cloudera.org/c/10643/ right after this. Then we may be able to let the cherrypick-2.x-and-test job move forward for several commits. http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java File fe/src/test/java/org/apache/impala/analysis/AuditingTest.java: http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuditingTest.java@316 PS1, Line 316: ANY > This is actually a bug that got fixed here: https://gerrit.cloudera.org/c/1 Sure! http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/12292/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1804 PS1, Line 1804: // Insufficient privileges on column that is not a complex type, trying to access member. > line too long (93 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/12292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ic96ae184fccdc88ba970b5adcd501da1966accb9 Gerrit-Change-Number: 12292 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 29 Jan 2019 23:13:59 +0000 Gerrit-HasComments: Yes
