Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC ...................................................................... Patch Set 4: Code-Review+2 (2 comments) LGTM, i ll leave addressing my latest comment to your judgement http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@292 PS3, Line 292: } : return status; > Made that change. The update time reported is not quite right in that case true, should we return a -1 in that case? (see other comment below) http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc@1123 PS4, Line 1123: if (ms_since_last_update != nullptr) *ms_since_last_update = ms_since_update should we return a value of -1 or something if last_topic_update_time_ms_ == 0 ?? -- To view, visit http://gerrit.cloudera.org:8080/12407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9 Gerrit-Change-Number: 12407 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 08 Feb 2019 23:59:54 +0000 Gerrit-HasComments: Yes
