Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc@1123 PS4, Line 1123: if (ms_since_last_update != nullptr) *ms_since_last_update = ms_since_update > should we return a value of -1 or something if last_topic_update_time_ms_ = I figured it didn't really make a difference. I'm not sure how likely it's even to trigger this - Impala doesn't generally start up if it can't connect to the statestore. -- To view, visit http://gerrit.cloudera.org:8080/12407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9 Gerrit-Change-Number: 12407 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 09 Feb 2019 00:10:50 +0000 Gerrit-HasComments: Yes
