Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12426
Change subject: IMPALA-5031: signed overflow is undefined behavior ...................................................................... IMPALA-5031: signed overflow is undefined behavior Tis patch fixes a signed overflow in the test StringToDecimal.LargeDecimals. The interesting part of the backtrace is: util/string-parser.h:397:14: runtime error: signed integer overflow: 0x4b3b4ca85a86c47a098a223fffffffff * 10 cannot be represented in type '__int128' #0 void StringParser::ApplyExponent<__int128>(int, int, signed char, __int128*, int*, int*) util/string-parser.h:397:14 #1 DecimalValue<__int128> StringParser::StringToDecimal<__int128> (char const*, int, int, int, bool, StringParser::ParseResult*) util/string-parser.h:221:5 #2 void VerifyParse<__int128>(string const&, int, int, bool, DecimalValue<__int128> const&, StringParser::ParseResult) runtime/decimal-test.cc:53:25 #3 void VerifyParse<__int128>(string const&, int, int, DecimalValue<__int128> const&, StringParser::ParseResult) runtime/decimal-test.cc:65:3 #4 StringToDecimal_LargeDecimals_Test::TestBody() runtime/decimal-test.cc:443:3 Change-Id: Ifb4effa291e1e4dac62b84251c74c483d99b06e7 --- M be/src/util/string-parser.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/12426/1 -- To view, visit http://gerrit.cloudera.org:8080/12426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb4effa291e1e4dac62b84251c74c483d99b06e7 Gerrit-Change-Number: 12426 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org>