Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12426 )
Change subject: IMPALA-5031: signed overflow is undefined behavior ...................................................................... Patch Set 1: Code-Review+2 Ok, it looks like the code catches the overflow when the caller checks precision and scale. -- To view, visit http://gerrit.cloudera.org:8080/12426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb4effa291e1e4dac62b84251c74c483d99b06e7 Gerrit-Change-Number: 12426 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 18:56:56 +0000 Gerrit-HasComments: No
