Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )
Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-7935: Disable /catalog_object in local catalog mode. : > nit: Try to fit it in a single line. Something like Done http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@10 PS1, Line 10: since metadata is partially fetched on demand. Removed hyperlinks : to the /catalog_object endpoints wh > Mention that getTCatalogObject() is not supported in LocalCatalog mode sinc Done http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@103 PS1, Line 103: : webserver->RegisterUrlCallback("/catalog_object", "catalog_object.tmpl", > Don't think there is any value in defining this end point when we don't sup Done http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@544 PS1, Line 544: } : > don't think we need to pass this. We can infer the same depending on whethe Done http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@557 PS1, Line 557: > DCHECK !use_local_catalog? Done http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py@348 PS1, Line 348: assert 'No URI handler for '/catalog_object''\ : in impalad.service.read_debug_webpage('/catalog_obje > Instead I think we should check that there is no handler for /catalog_objec Done -- To view, visit http://gerrit.cloudera.org:8080/12443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c Gerrit-Change-Number: 12443 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Feb 2019 14:03:13 +0000 Gerrit-HasComments: Yes
