Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )
Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@103 PS4, Line 103: if(!FLAGS_use_local_catalog) { I think you missed the comment part. Add a quick comment? http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@541 PS4, Line 541: if(!FLAGS_use_local_catalog){ Is this needed? The template file uses fqtn only when use_local_catalog is set? http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@549 PS4, Line 549: Value use_local_catalog(FLAGS_use_local_catalog); : table_obj.AddMember("use_local_catalog", FLAGS_use_local_catalog, : document->GetAllocator()) Why this? http://gerrit.cloudera.org:8080/#/c/12443/4/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12443/4/tests/custom_cluster/test_web_pages.py@42 PS4, Line 42: @pytest.mark.execute_serially : def test_observability(self): : # Make sure /catalog_object endpoint is enabled. : response = requests.get("http://localhost:25000/catalog_object";) : assert 'No URI handler for '/catalog_object''\ : not in response Why here instead of tests/webserver/test_web_pages.py ? This is dedicated to "custom_cluster" tests/ http://gerrit.cloudera.org:8080/#/c/12443/4/www/catalog.tmpl File www/catalog.tmpl: http://gerrit.cloudera.org:8080/#/c/12443/4/www/catalog.tmpl@133 PS4, Line 133: <a href='catalog_object?object_type=DATABASE&object_name={{name}}' id='{{name}}'> I don't see why the whole {{num_tables}} should be in a href. How about something like <h2 class="panel-title"> {{?use_local_catalog}} {{name}} {{/use_local_catalog}} {{^use_local_catalog}} <a href .../> {{/use_local_catalog}} <span class="pull-right">{{num_tables}} table(s)</span> </h2> -- To view, visit http://gerrit.cloudera.org:8080/12443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c Gerrit-Change-Number: 12443 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 19 Feb 2019 22:20:06 +0000 Gerrit-HasComments: Yes
