Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12436 )
Change subject: IMPALA-8182: Add single-node plan to PlanCtx ...................................................................... Patch Set 1: (6 comments) Few minor comments, lgtm otherwise. http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/planner/Planner.java@66 PS1, Line 66: public static final class QueryPlan { Comment. http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/planner/Planner.java@99 PS1, Line 99: Returns a list of plan fragments for executing an analyzed parse tree. : * May return a single-node or distributed executable plan. If enabled (through a : * query option), computes runtime filters for dynamic partition pruning. Update http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/planner/Planner.java@141 PS1, Line 141: plan.rootFragment_ = rootFragment; Set this after L179 instead of doing it twice. http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/planner/Planner.java@244 PS1, Line 244: Return a list of plans Update. http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/planner/Planner.java@258 PS1, Line 258: plan.parallelPlans_ = parallelPlans; Do it in L253? http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/12436/1/fe/src/main/java/org/apache/impala/service/Frontend.java@212 PS1, Line 212: public List<PlanFragment> getPlan() { return planRoots_; } Looks like there are very limited callers for this. Redo them to use the new way? -- To view, visit http://gerrit.cloudera.org:8080/12436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983473f259df8af17d8dd38e497fe33e839cd0dc Gerrit-Change-Number: 12436 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 19:42:10 +0000 Gerrit-HasComments: Yes
