Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12436
to look at the new patch set (#2).
Change subject: IMPALA-8182: Add single-node plan to PlanCtx
......................................................................
IMPALA-8182: Add single-node plan to PlanCtx
Historically, the Impala planner is a function: AST in one end, Thrift
plan out the other. The planner itself creates a rich intermediate plan
representation, but none of those objects were available for testing,
forcing all tests, no matter how detailed, to run as end-to-end tests:
SQL in one end, verify a (very abbreviated) DESCRIBE output out the
other.
A recent change introduced the PlanCtx that provided access to the
parallelized plan fragments. Doing so allowed adding a variety of
cardinality tests.
It turns out that additional testing requires access to the "single node
plan" in order to verify things like join cardinality.
This patch generalizes the previous patch to provide access to all
intermediate plan structures created during planning. Doing so enables
full unit testing of all planning steps.
Tests: This fix is refactoring only. Reran all FE tests.
Change-Id: I983473f259df8af17d8dd38e497fe33e839cd0dc
---
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/planner/CardinalityTest.java
3 files changed, 66 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/12436/2
--
To view, visit http://gerrit.cloudera.org:8080/12436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I983473f259df8af17d8dd38e497fe33e839cd0dc
Gerrit-Change-Number: 12436
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Paul Rogers <[email protected]>
