Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12461
Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness ...................................................................... IMPALA-8183: fix test_reportexecstatus_retry flakiness The test is designed to cause ReportExecStatus() rpcs to fail by backing up the control service queue. Prior to IMPALA-4555, after a failed ReportExecStatus() we would wait 'report_status_retry_interval_ms' between retries, which was 100ms by default and wasn't touched by the test. That 100ms was right on the edge of being enough time for the coordinator to keep up with processing the reports, so that some would fail but most would succeed. It was always possible that we could hit 2990 in this setup, but it was unlikely. Now, we wait 'status_report_interval_ms'. By default, this is 5000ms, so it should give the coordinator even more time and make these issues less likely. However, the test sets 'status_report_interval_ms' to 10ms, which isn't nearly enough time for the coordinator to do its processing, causing lots of the ReportExecStatus() rpcs to fail and making us hit 2990 pretty often. The solution is to set 'status_report_interval_ms' to 100ms in the test, which roughly achieves the same retry frequency as before. The same change is made to a similar test test_reportexecstatus_timeout. Testing: - Ran test_reportexecstatus_retry in a loop 400 times without seeing a failure. It previously repro-ed for me about once per 50 runs. - Manually verified that both tests are still hitting the error paths that they are supposed to be testing. Change-Id: I7027a6e099c543705e5845ee0e5268f1f9a3fb05 --- M tests/custom_cluster/test_rpc_timeout.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/12461/1 -- To view, visit http://gerrit.cloudera.org:8080/12461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7027a6e099c543705e5845ee0e5268f1f9a3fb05 Gerrit-Change-Number: 12461 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]>
