Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12461 )
Change subject: IMPALA-8183: fix test_reportexecstatus_retry flakiness ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12461/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12461/1//COMMIT_MSG@12 PS1, Line 12: between retries, which was 100ms b > Please also mention that this flag is removed after IMPALA-4555. Done http://gerrit.cloudera.org:8080/#/c/12461/1//COMMIT_MSG@16 PS1, Line 16: IMPALA-2990 in this setup, but it was unlikely. > I had to think for a while, if you say "IMPALA-2990" it would be clearer Done http://gerrit.cloudera.org:8080/#/c/12461/1//COMMIT_MSG@19 PS1, Line 19: and we instead wait 'status_report_interval_ms' between retries. By > between retries Done http://gerrit.cloudera.org:8080/#/c/12461/1//COMMIT_MSG@24 PS1, Line 24: ReportExecStatus() rpcs to fail and making us hit IMPALA-2990 pretty > IMPALA-2990 Done -- To view, visit http://gerrit.cloudera.org:8080/12461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7027a6e099c543705e5845ee0e5268f1f9a3fb05 Gerrit-Change-Number: 12461 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Tue, 12 Feb 2019 23:20:20 +0000 Gerrit-HasComments: Yes
