Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12451 )
Change subject: IMPALA-8187: UDF samples hide symbols by default ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Thanks for doing this! LGTM. http://gerrit.cloudera.org:8080/#/c/12451/3/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/12451/3/tests/query_test/test_udfs.py@440 PS3, Line 440: create function `{0}`.unexported() returns BIGINT LOCATION '{1}' Should this be unexported_symbol()? -- To view, visit http://gerrit.cloudera.org:8080/12451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie17b74b9bce9cc6962393017879b65409ce23b28 Gerrit-Change-Number: 12451 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 13 Feb 2019 00:33:24 +0000 Gerrit-HasComments: Yes
