Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12451 )
Change subject: IMPALA-8187: UDF samples hide symbols by default ...................................................................... IMPALA-8187: UDF samples hide symbols by default Testing: Ran UDF tests, confirmed that changing the compile flags without adding IMPALA_UDF_EXPORT caused them to fail because they couldn't find the symbols. Added a test to check that symbols are actually hidden. Change-Id: Ie17b74b9bce9cc6962393017879b65409ce23b28 Reviewed-on: http://gerrit.cloudera.org:8080/12451 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/CMakeLists.txt M be/src/testutil/CMakeLists.txt M be/src/testutil/test-udas.cc M be/src/testutil/test-udfs.cc M be/src/udf/udf.h M be/src/udf_samples/CMakeLists.txt M be/src/udf_samples/hyperloglog-uda.cc M be/src/udf_samples/uda-sample.cc M be/src/udf_samples/udf-sample.cc M tests/query_test/test_udfs.py 10 files changed, 188 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie17b74b9bce9cc6962393017879b65409ce23b28 Gerrit-Change-Number: 12451 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]>
