Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12524/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12524/1/tests/webserver/test_web_pages.py@124 PS1, Line 124: self.client.cancel(query_handle) > Shouldn't we cancel the query after getting the memz output? Good point, fixed. Looks like the cancelation was slow enough to work in my testing. :( -- To view, visit http://gerrit.cloudera.org:8080/12524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8 Gerrit-Change-Number: 12524 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 19 Feb 2019 18:58:13 +0000 Gerrit-HasComments: Yes
