Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12524 )
Change subject: IMPALA-8209: Include fragment instance ID in memz/ breakdown ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Thanks for fixing the padding, that should make things more consistent http://gerrit.cloudera.org:8080/#/c/12524/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12524/3/tests/webserver/test_web_pages.py@124 PS3, Line 124: memz_breakdown = self.get_debug_page(self.MEMZ_URL)['detailed'] I think everything except close_query needs to be inside the try block - we don't want it to run if wait_for_state throws an exception, right? -- To view, visit http://gerrit.cloudera.org:8080/12524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73bf06bf95c88186b16fd03243de9bac946c5cc8 Gerrit-Change-Number: 12524 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 00:32:32 +0000 Gerrit-HasComments: Yes
