Joe McDonnell has uploaded this change for review. (
http://gerrit.cloudera.org:8080/12557
Change subject: IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks
......................................................................
IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks
DiskInfo::GetDeviceNames() assumes a device name pattern where
the last digits can be removed to get the main disk device
(i.e. sda3 -> sda). NVME devices have a naming pattern of
nvme{device_id}n{namespace_id}p{partition_id} where the main
disk device removes the p{partition_id} part. This difference
in naming prevents DiskInfo::GetDeviceNames() from looking
up the associated information in /sys/block to find whether
it is a rotational device (and thus use an appropriate
number of DiskIo threads).
This adds a condition to detect an NVME device name and
handle it correctly.
Tested this on an AWS m5-4xlarge, which is a Nitro instance
type that exposes the main disk as an NVME device.
Change-Id: I4d5bd93b4b09682a8c8248e7aa123d23d27cfeb4
---
M be/src/util/disk-info.cc
1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/12557/1
--
To view, visit http://gerrit.cloudera.org:8080/12557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d5bd93b4b09682a8c8248e7aa123d23d27cfeb4
Gerrit-Change-Number: 12557
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
