Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12557 )
Change subject: IMPALA-8188: Fix DiskInfo::GetDeviceNames() for NVME disks ...................................................................... Patch Set 1: > Could you extract the function and add a unit test that the regexp > does what it's supposed to? > > Thanks! Done -- To view, visit http://gerrit.cloudera.org:8080/12557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5bd93b4b09682a8c8248e7aa123d23d27cfeb4 Gerrit-Change-Number: 12557 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Sat, 23 Feb 2019 00:50:28 +0000 Gerrit-HasComments: No
