Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12562 )
Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12562/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12562/2//COMMIT_MSG@14 PS2, Line 14: Testing: added a new PlannerTest case for this case. Reran the query Can you also add an end-to-end test here: ./testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test It might be more interesting to use something with an analytic function that returns different values to provide more proof that it's working as intended, e.g. SELECT FIRST_VALUE(0) OVER (ORDER BY 0 ASC), row_number() over (order by 0 ASC) http://gerrit.cloudera.org:8080/#/c/12562/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/12562/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@257 PS2, Line 257: runPlannerTestFile("ad-hoc"); This file doesn't seem to be checked in. -- To view, visit http://gerrit.cloudera.org:8080/12562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a57f3791ce9e41fe0ba79dc5834e762341c74e Gerrit-Change-Number: 12562 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 25 Feb 2019 17:47:20 +0000 Gerrit-HasComments: Yes
