Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12562 )
Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run ...................................................................... Patch Set 3: (2 comments) Addressed review comments. Rerunning pre-review tests to ensure the new end-to-end test works correctly. http://gerrit.cloudera.org:8080/#/c/12562/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12562/2//COMMIT_MSG@14 PS2, Line 14: Testing: > Can you also add an end-to-end test here: ./testdata/workloads/functional-q Done http://gerrit.cloudera.org:8080/#/c/12562/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/12562/2/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@257 PS2, Line 257: TQueryOptions options = new TQueryOptions(); > This file doesn't seem to be checked in. Fixed. Shouldn't have been pushed to Gerrit. -- To view, visit http://gerrit.cloudera.org:8080/12562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a57f3791ce9e41fe0ba79dc5834e762341c74e Gerrit-Change-Number: 12562 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 25 Feb 2019 22:14:15 +0000 Gerrit-HasComments: Yes
