Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear ...................................................................... Patch Set 1: (1 comment) Thanks for working on this! I also need to rework the dependencies. This validation should happen even if you run "make $TESTNAME" (where $TESTNAME is in the unified backend test executable). I will put a change together. http://gerrit.cloudera.org:8080/#/c/12620/1/bin/validate-unified-backend-test-filters.py File bin/validate-unified-backend-test-filters.py: http://gerrit.cloudera.org:8080/#/c/12620/1/bin/validate-unified-backend-test-filters.py@58 PS1, Line 58: print("FAILED: The unified backend test executable contains tests that are\n" : " missing from the CMake test filters. Consider adding them in\n" : " be/src/util/CMakeLists.txt. Missing tests:") This is going to spread beyond be/src/util/CMakeLists.txt pretty soon. Maybe something like: FAILED: The unified backend test executable contains tests that are missing from the CMake test filters specified via the ADD_UNIFIED_BE_TEST/ADD_UNIFIED_BE_LSAN_TEST macros in CMakeLists.txt. To fix this, add a pattern in the appropriate CMakeLists.txt to match the following tests: ... -- To view, visit http://gerrit.cloudera.org:8080/12620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8 Gerrit-Change-Number: 12620 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 04:50:41 +0000 Gerrit-HasComments: Yes
