Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12620 )
Change subject: Make error message for backend test validation more clear ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12620/2/bin/validate-unified-backend-test-filters.py File bin/validate-unified-backend-test-filters.py: http://gerrit.cloudera.org:8080/#/c/12620/2/bin/validate-unified-backend-test-filters.py@77 PS2, Line 77: print("FAILED: The unified backend test executable contains tests that are\n" : "missing from the CMake test filters specified via the\n" : "ADD_UNIFIED_BE_TEST/ADD_UNIFIED_BE_LSAN_TEST macros in CMakeLists.txt.\n" : "To fix this, add a pattern in the appropriate CMakeLists.txt to match\n" : "the following tests:") There are two different errors. The first one (above at without_filter != with_filter) is where a test is in the binary but not specified in filters. This description needs to move there. The second one is where a filter doesn't match anything in the binary (this len(filters_without_tests) > 0 condition here). It might be worth updating this second error as well: FAILED: Some test filters specified by ADD_UNIFIED_BE_TEST/ADD_UNIFIED_BE_LSAN_TEST macros in CMakeLists.txt do not match any tests in the unified backend test executable. This can happen if there is a bogus filter or if some tests are not being included in the test executable (e.g. if a new test file is missing from the test library). The invalid test filters are: -- To view, visit http://gerrit.cloudera.org:8080/12620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic206044c8f119b6ee164eb2e6121ec67e71dafa8 Gerrit-Change-Number: 12620 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Wed, 27 Feb 2019 20:11:57 +0000 Gerrit-HasComments: Yes
