Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 )
Change subject: IMPALA-7916: Remove support for authorization policy file flag ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java: http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java@46 PS1, Line 46: public SentryAuthorizationConfig(String serverName, String sentryConfigFile, String policyProviderClassName) { line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java@73 PS1, Line 73: public static SentryAuthorizationConfig createHadoopGroupAuthConfig(String serverName, String sentryConfigFile) { line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java@128 PS1, Line 128: return !Strings.isNullOrEmpty(serverName_) || !Strings.isNullOrEmpty(sentryConfig_.getConfigFile()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@828 PS1, Line 828: config = SentryAuthorizationConfig.createHadoopGroupAuthConfig("server1", sentryConfig); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@866 PS1, Line 866: config = SentryAuthorizationConfig.createHadoopGroupAuthConfig("server1", "/path/does/not/exist.xml"); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@877 PS1, Line 877: config = new SentryAuthorizationConfig("server1", sentryConfig, "ClassDoesNotExist"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@887 PS1, Line 887: config = new SentryAuthorizationConfig("server1", sentryConfig, this.getClass().getName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java File fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java: http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/authorization/sentry/SentryProxyTest.java@60 PS1, Line 60: SENTRY_SERVER, System.getenv("IMPALA_HOME") + "/fe/src/test/resources/sentry-site.xml"); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12637/1/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/12637/1/tests/authorization/test_authorization.py@67 PS1, Line 67: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/12637/1/tests/authorization/test_authorization.py@67 PS1, Line 67: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/12637/1/tests/authorization/test_authorization.py@77 PS1, Line 77: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/12637/1/tests/authorization/test_authorization.py@77 PS1, Line 77: flake8: E251 unexpected spaces around keyword / parameter equals -- To view, visit http://gerrit.cloudera.org:8080/12637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a52c2d5d35f58fbff8c088fb0bf30169625ebd Gerrit-Change-Number: 12637 Gerrit-PatchSet: 1 Gerrit-Owner: Austin Nobis <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 17:51:38 +0000 Gerrit-HasComments: Yes
