Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 )
Change subject: IMPALA-7916: Remove support for authorization policy file flag ...................................................................... Patch Set 2: (6 comments) I did a quick look at this CR and gave some quick comments. Will review more later. http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java: http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java@22 PS1, Line 22: import org.apache.impala.authorization.AuthorizationConfig; this import doesn't seem used. http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationConfig.java@28 PS1, Line 28: * Impala authorization configuration with Sentry. : */ : public class SentryAuthorizationCon same thing with these imports http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@713 PS1, Line 713: nit: indentation off http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@a143 PS1, Line 143: : : : : : : : : : : : : : : : : : : : : We need to refactor this test. I don't think it makes sense to use parameterized JUnit anymore. http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@a834 PS1, Line 834: we need this test. http://gerrit.cloudera.org:8080/#/c/12637/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@a1026 PS1, Line 1026: we need this test -- To view, visit http://gerrit.cloudera.org:8080/12637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a52c2d5d35f58fbff8c088fb0bf30169625ebd Gerrit-Change-Number: 12637 Gerrit-PatchSet: 2 Gerrit-Owner: Austin Nobis <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 18:09:46 +0000 Gerrit-HasComments: Yes
