Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 )
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@5631 PS4, Line 5631: "cast('2013-09-26 12:00:00' as timestamp)) as string)", "2013-09-26 12:00:00.000000000"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@5688 PS4, Line 5688: "cast('2013-09-26 12:00:00' as timestamp)) as string)", "2014-09-26 12:00:00.000000000"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@7044 PS4, Line 7044: TestStringValue("cast(cast('09:10:11+01:30' as timestamp) as string)", "09:10:11.000000000"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/12498/4/be/src/exprs/expr-test.cc@7045 PS4, Line 7045: TestStringValue("cast(cast('09:10:11-01:30' as timestamp) as string)", "09:10:11.000000000"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/12498/4/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: http://gerrit.cloudera.org:8080/#/c/12498/4/tests/data_errors/test_data_errors.py@226 PS4, Line 226: ' flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/12498/4/tests/data_errors/test_data_errors.py@226 PS4, Line 226: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12498/4/tests/hs2/test_fetch.py File tests/hs2/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/12498/4/tests/hs2/test_fetch.py@137 PS4, Line 137: 1 flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/12498/4/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/12498/4/tests/query_test/test_aggregation.py@78 PS4, Line 78: 0 flake8: E501 line too long (95 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/12498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43 Gerrit-Change-Number: 12498 Gerrit-PatchSet: 4 Gerrit-Owner: Robbie Zhang <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 02 Mar 2019 11:30:01 +0000 Gerrit-HasComments: Yes
