Hello Greg Rahn, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12498
to look at the new patch set (#4).
Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different
types
......................................................................
IMPALA-8108: Impala query returns TIMESTAMP values in different types
Impala uses function boost::posix_time::to_simple_string(time_duration)
to convert timestamp to a string and to_simple_string() remove fractional
seconds if they are all zeros.
In order to output timestamp values in the same format, we add padding
zeros if where isn't fractional seconds.
TESTING:
Added end-to-end test test_timestamps to verify the results.
Because all timestamp values have fractional seconds, expected results
in test data and test scripts are updated as well.
Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
---
M be/src/exprs/expr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/runtime/timestamp-value.cc
M
testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
M
testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
M testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test
M
testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M
testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test
M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test
M testdata/workloads/functional-query/queries/QueryTest/distinct.test
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-filters.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view-limit.test
M testdata/workloads/functional-query/queries/QueryTest/inline-view.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/joins.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-overflow-ts.test
M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_limit.test
M testdata/workloads/functional-query/queries/QueryTest/limit.test
M
testdata/workloads/functional-query/queries/QueryTest/local-timestamp-functions.test
M
testdata/workloads/functional-query/queries/QueryTest/multiple-filesystems.test
M
testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-continue-on-error.test
M
testdata/workloads/functional-query/queries/QueryTest/out-of-range-timestamp-local-tz-conversion.test
M testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test
M
testdata/workloads/functional-query/queries/QueryTest/parquet-int64-timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M
testdata/workloads/functional-query/queries/QueryTest/select-lazy-timestamp.test
M testdata/workloads/functional-query/queries/QueryTest/subquery.test
A testdata/workloads/functional-query/queries/QueryTest/timestamps.test
M testdata/workloads/functional-query/queries/QueryTest/top-n.test
M testdata/workloads/functional-query/queries/QueryTest/truncate-table.test
M testdata/workloads/functional-query/queries/QueryTest/udf.test
M testdata/workloads/functional-query/queries/QueryTest/union.test
M
testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test
M testdata/workloads/functional-query/queries/QueryTest/views.test
M tests/custom_cluster/test_hive_parquet_timestamp_conversion.py
M tests/data_errors/test_data_errors.py
M tests/hs2/test_fetch.py
M tests/query_test/test_aggregation.py
A tests/query_test/test_timestamps.py
47 files changed, 1,160 insertions(+), 860 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12498/4
--
To view, visit http://gerrit.cloudera.org:8080/12498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad9a4659ff6d5353329e9d062886ee80296b5b43
Gerrit-Change-Number: 12498
Gerrit-PatchSet: 4
Gerrit-Owner: Robbie Zhang <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Greg Rahn <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
