Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 )
Change subject: IMPALA-8273 : Change metastore configuration template to not exclude impala specific parameters ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@9 PS1, Line 9: When HMS configuration key "hive.metastore.notification.parameters.exclude.patterns" Line overflow. http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@17 PS1, Line 17: failing from MetastoreEventsProcessingTest class. Job currently running. Shouldn't the failures be deterministic if this config is missing? I'm curious how the patch made it to the master in that case. Am I missing something? http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1017 PS1, Line 1017: LOG.info("This is a test print from test"); Remove? http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/resources/postgresql-hive-site.xml.template File fe/src/test/resources/postgresql-hive-site.xml.template: http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/resources/postgresql-hive-site.xml.template@240 PS1, Line 240: <property> Add a comment, why this is needed? -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Mar 2019 17:29:42 +0000 Gerrit-HasComments: Yes
