Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 )
Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@9 PS1, Line 9: > Line overflow. Done http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@17 PS1, Line 17: Testing done: > Shouldn't the failures be deterministic if this config is missing? I'm curi the failures are deterministic when you uprade the cdh components which include the HMS config change. All the tests which depend on the flag impala.disableHmsSync in table/partition parameters are failing. http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1017 PS1, Line 1017: assertEquals(numEventsReceivedBefore + 5, response.getEvents_received()); > Remove? Done http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/resources/postgresql-hive-site.xml.template File fe/src/test/resources/postgresql-hive-site.xml.template: http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/resources/postgresql-hive-site.xml.template@240 PS1, Line 240: <!-- This property is required so that table parameters do not exclude keys which certain features > Add a comment, why this is needed? Done -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2019 17:56:50 +0000 Gerrit-HasComments: Yes
