Hello Thomas Marshall,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12694
to review the following change.
Change subject: IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored
......................................................................
IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored
When creating a Kudu table, we would use the 'PRIMARY KEY (...)' clause
to determine which columns made up the primary key, but the order of
those columns would be ignored. Thus a statement like:
CREATE TABLE (x int, y int, PRIMARY KEY (y, x)) STORED AS KUDU;
would silently create a table with an (x,y) primary key instead of a
(y,x) key. This can have substantial performance implications.
This fixes the frontend to correctly throw an error in this case.
This might be incompatible if someone was previously relying on the bug,
but I think it's worth fixing because it was clearly doing the wrong
thing.
Change-Id: I0499cee7c532db19cddac3906198d965b27ea604
---
M fe/src/main/java/org/apache/impala/common/PrintUtils.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/util/PrintUtilsTest.java
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
4 files changed, 47 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/12694/1
--
To view, visit http://gerrit.cloudera.org:8080/12694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0499cee7c532db19cddac3906198d965b27ea604
Gerrit-Change-Number: 12694
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
