Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12694 )
Change subject: IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored ...................................................................... IMPALA-8283. Order of Kudu PRIMARY KEYs can be silently ignored When creating a Kudu table, we would use the 'PRIMARY KEY (...)' clause to determine which columns made up the primary key, but the order of those columns would be ignored. Thus a statement like: CREATE TABLE (x int, y int, PRIMARY KEY (y, x)) STORED AS KUDU; would silently create a table with an (x,y) primary key instead of a (y,x) key. This can have substantial performance implications. This fixes the frontend to correctly throw an error in this case. This might be incompatible if someone was previously relying on the bug, but I think it's worth fixing because it was clearly doing the wrong thing. Change-Id: I0499cee7c532db19cddac3906198d965b27ea604 Reviewed-on: http://gerrit.cloudera.org:8080/12694 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Todd Lipcon <[email protected]> --- M fe/src/main/java/org/apache/impala/common/PrintUtils.java M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java M fe/src/test/java/org/apache/impala/util/PrintUtilsTest.java M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test 4 files changed, 51 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0499cee7c532db19cddac3906198d965b27ea604 Gerrit-Change-Number: 12694 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
