Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 )
Change subject: IMPALA-8312 : Alter database operations have race condition ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java File fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java: http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@66 PS5, Line 66: private static int numReaders_ = 10; : // number of writer threads which change the database. We only need one currently : // since all the alterDatabase calls are serialized by metastoreDdlLock_ in : // CatalogOpExecutor : private static int numWriters_ = 1; Can be static final. Use upper case for static final variable names. http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@72 PS5, Line 72: // barrier to make sure that readers and writers start at the same time : private static final CyclicBarrier barrier_ = : new CyclicBarrier(numReaders_ + numWriters_); : // toggle switch to change the database owner from user_1 to user_2 in each : // consecutive alter database call : private static final AtomicBoolean toggler_ = new AtomicBoolean(false); I feel like all these variables should not be static especially since we may add another test in the future and need to reset the toggler_, etc. http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@132 PS5, Line 132: nit: remove new line http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@150 PS5, Line 150: nit: remove new line http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@224 PS5, Line 224: throw new Exception should we just use fail() instead of throwing an exception? -- To view, visit http://gerrit.cloudera.org:8080/12789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32c8c96a6029bf9d9db37ea8315f6c9603b5a2fc Gerrit-Change-Number: 12789 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Mar 2019 18:46:01 +0000 Gerrit-HasComments: Yes
