Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 )
Change subject: IMPALA-8312 : Alter database operations have race condition ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/12789/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12789/5//COMMIT_MSG@12 PS5, Line 12: partially updated database object becoming visible to a reading thread causing nit: line overflows http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/main/java/org/apache/impala/catalog/Db.java@71 PS5, Line 71: AtomicReference Is there any advantage in using AtomicReference when any changes to the parent Db only occur under an exclusive version lock? http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java File fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java: http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@80 PS5, Line 80: public static void setUpTest() throws ImpalaException { Add method doc? http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@131 PS5, Line 131: ReaderTask ValidateDbOwnerTask or something? http://gerrit.cloudera.org:8080/#/c/12789/5/fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java@149 PS5, Line 149: WriterTask Better name? -- To view, visit http://gerrit.cloudera.org:8080/12789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32c8c96a6029bf9d9db37ea8315f6c9603b5a2fc Gerrit-Change-Number: 12789 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Mar 2019 21:18:24 +0000 Gerrit-HasComments: Yes
