Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12819 )
Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12819/1/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java File fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java: http://gerrit.cloudera.org:8080/#/c/12819/1/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java@70 PS1, Line 70: if (((StringLiteral) result).getStringValue().length() > MAX_STRING_LITERAL_SIZE) I think we actually want to do this on the C++ side before it is sent to Java. The problem with doing it on the Java side is that at this point we have already allocated a Java string literal up to 2GB in addition to the C++ string. One follow-on from this is that we'd like to be able to run tests with smaller JVM heap sizes (e.g. 2GB). -- To view, visit http://gerrit.cloudera.org:8080/12819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8265cd3705b8f8ee66d0fd94434e03c7acff7632 Gerrit-Change-Number: 12819 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 21 Mar 2019 20:54:06 +0000 Gerrit-HasComments: Yes
