Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12814 )
Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@405 PS5, Line 405: TColumnValue val = FeSupport.EvalExprWithoutRow(offset, analyzer.getQueryCtx(), 65_536); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java File fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java: http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java@338 PS5, Line 338: TColumnValue val1 = FeSupport.EvalExprWithoutRow(e1, analyzer.getQueryCtx(), 65_536); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java@339 PS5, Line 339: TColumnValue val2 = FeSupport.EvalExprWithoutRow(e2, analyzer.getQueryCtx(), 65_536); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java: http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java@288 PS5, Line 288: defaultValLiteral = LiteralExpr.create(castLiteral, analyzer.getQueryCtx(), 65_536); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java File fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java: http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java@67 PS5, Line 67: Expr result = LiteralExpr.create(expr, analyzer.getQueryCtx(), MAX_STRING_LITERAL_SIZE); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/service/FeSupport.java File fe/src/main/java/org/apache/impala/service/FeSupport.java: http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/service/FeSupport.java@166 PS5, Line 166: public static TColumnValue EvalExprWithoutRow(Expr expr, TQueryCtx queryCtx, int maxResultSize) line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/12814/5/fe/src/main/java/org/apache/impala/service/FeSupport.java@219 PS5, Line 219: return NativeEvalExprsWithoutRow(thriftExprBatch, thriftQueryContext, maxResultSize); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b078113ccc1aa49b0cea0c86dff2e02e1dd0e23 Gerrit-Change-Number: 12814 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 30 Mar 2019 01:23:52 +0000 Gerrit-HasComments: Yes
