Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 )
Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/4//COMMIT_MSG@7 PS4, Line 7: `wget http://169.254.169.254/` Please excuse the drive-by comment. Can we change the quotes to normale quotes to make sure that we don't break tooling that might somehow echo and interpret the commit message? If you decide to go with it, please change below, too. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 4 Gerrit-Owner: Hector Acosta <[email protected]> Gerrit-Reviewer: Hector Acosta <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Fri, 22 Mar 2019 18:00:40 +0000 Gerrit-HasComments: Yes
