Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 )
Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/2//COMMIT_MSG@9 PS2, Line 9: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/identify_ec2_instances.html > That says "check the instance identity document, including its signature". IIUC wget is not doing that. In order to verify the instance metadata returned by http://169.254.169.254/ we'd need to perform the steps outlined here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-identity-documents.html Verifying metadata signatures here seems like an overkill to me. This patch makes the assumption that if http://169.254.169.254/ is reachable then it's reasonable to assume that we're in an ec2 instance. we're just using /latest/dynamic/instance-identity/ as a documented url endpoint. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta <[email protected]> Gerrit-Reviewer: Hector Acosta <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Mon, 18 Mar 2019 04:30:06 +0000 Gerrit-HasComments: Yes
