Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 )
Change subject: Clean up generation of XML configuration files ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12930/2/fe/src/test/resources/sentry-site.xml.py File fe/src/test/resources/sentry-site.xml.py: http://gerrit.cloudera.org:8080/#/c/12930/2/fe/src/test/resources/sentry-site.xml.py@49 PS2, Line 49: 'sentry.store.jdbc.url': 'jdbc:postgresql://localhost:5432/${SENTRY_POLICY_DB}/;create=true' we should fix this JDBC URL: https://gerrit.cloudera.org/c/12894/3/fe/src/test/resources/sentry-site.xml.template -- To view, visit http://gerrit.cloudera.org:8080/12930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief4434d80baae0fd7be7ffe7b2e07bae1ac45e47 Gerrit-Change-Number: 12930 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Apr 2019 19:06:59 +0000 Gerrit-HasComments: Yes
