Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 )
Change subject: Clean up generation of XML configuration files ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12930/3/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/12930/3/bin/jenkins/critique-gerrit-review.py@72 PS3, Line 72: > flake8: E261 at least two spaces before inline comment I'm tempted to disable this warning. I guess it's part of PEP-8 and therefore standard but I find it very hard to see how it makes anything more readable: https://www.python.org/dev/peps/pep-0008/#inline-comments -- To view, visit http://gerrit.cloudera.org:8080/12930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief4434d80baae0fd7be7ffe7b2e07bae1ac45e47 Gerrit-Change-Number: 12930 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Apr 2019 21:40:25 +0000 Gerrit-HasComments: Yes
