Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 )
Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/FsType.java File fe/src/main/java/org/apache/impala/catalog/FsType.java: http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/FsType.java@25 PS4, Line 25: * Represents the type of filesystem being used. Typically associated with a This is somewhat redundant with the is*Filesystem() logic in FileSystemUtil.java. Maybe we should move this enum there so that it's easier to find the relate code. Or cross-reference it? Or share some of the implementation? Mainly just concerned that this is another place people have to update to add a filesystem. There's a more theoretical concern that maybe multiple URL schemes map to a single filesystem implementation, so the other code could recognise a filesystem that this doesn't. That seems far-fetched though. http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java: http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java@89 PS4, Line 89: return FsType.LOCAL; See comment on LocalFsTable http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@276 PS4, Line 276: return FsType.LOCAL; Is this right? I think this is a "Local" table in the sense that it's the "Local" catalog implementation. But it could be any table. http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/test/java/org/apache/impala/planner/ExplainTest.java File fe/src/test/java/org/apache/impala/planner/ExplainTest.java: http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/test/java/org/apache/impala/planner/ExplainTest.java@81 PS4, Line 81: partitions.add(createMockHdfsPartition("abfs://[email protected]" This is cool http://gerrit.cloudera.org:8080/#/c/12282/4/testdata/workloads/functional-planner/queries/PlannerTest/scan-node-fs-scheme.test File testdata/workloads/functional-planner/queries/PlannerTest/scan-node-fs-scheme.test: http://gerrit.cloudera.org:8080/#/c/12282/4/testdata/workloads/functional-planner/queries/PlannerTest/scan-node-fs-scheme.test@22 PS4, Line 22: S3 partitions=1/0 files=0 size=0B What's the deal with the 1/0? -- To view, visit http://gerrit.cloudera.org:8080/12282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b1b4a1bc1a24e9614e3b4dc5a61dc96d075d1c3 Gerrit-Change-Number: 12282 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 09 Apr 2019 18:19:46 +0000 Gerrit-HasComments: Yes
