Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 )
Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@772 PS5, Line 772: public SampledPartitionMetadata(long partitionId, FileSystemUtil.FsType partitionFsType) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1323 PS5, Line 1323: for (Map.Entry<FileSystemUtil.FsType, Long> partsPerFs : numPartitionsPerFs_.entrySet()) { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/test/java/org/apache/impala/planner/ExplainTest.java File fe/src/test/java/org/apache/impala/planner/ExplainTest.java: http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/test/java/org/apache/impala/planner/ExplainTest.java@99 PS5, Line 99: partitions.add(createMockHdfsPartition("s3a://dummy-bucket/dummy-part-7", FileSystemUtil.FsType.S3)); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/test/java/org/apache/impala/planner/ExplainTest.java@100 PS5, Line 100: partitions.add(createMockHdfsPartition("s3a://dummy-bucket/dummy-part-8", FileSystemUtil.FsType.S3)); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/test/java/org/apache/impala/planner/ExplainTest.java@101 PS5, Line 101: partitions.add(createMockHdfsPartition(dummyTblPath + "/dummy-part-9", FileSystemUtil.FsType.HDFS)); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/test/java/org/apache/impala/planner/ExplainTest.java@102 PS5, Line 102: partitions.add(createMockHdfsPartition(dummyTblPath + "/dummy-part-10", FileSystemUtil.FsType.HDFS)); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/12282/5/fe/src/test/java/org/apache/impala/planner/ExplainTest.java@148 PS5, Line 148: private HdfsPartition createMockHdfsPartition(String path, FileSystemUtil.FsType fsType) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b1b4a1bc1a24e9614e3b4dc5a61dc96d075d1c3 Gerrit-Change-Number: 12282 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 09 Apr 2019 20:59:11 +0000 Gerrit-HasComments: Yes
