Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 )
Change subject: IMPALA-8309: add user authorization_provider flag ...................................................................... Patch Set 5: (24 comments) http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py File tests/authorization/test_provider.py: http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@21 PS5, Line 21: import time flake8: F401 'time' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@25 PS5, Line 25: from tests.util.filesystem_utils import IS_LOCAL flake8: F401 'tests.util.filesystem_utils.IS_LOCAL' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@28 PS5, Line 28: from tests.common.impala_test_suite import ImpalaTestSuite flake8: F401 'tests.common.impala_test_suite.ImpalaTestSuite' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.CATALOGD_ARGS' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.IMPALA_LOG_DIR' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.DEFAULT_QUERY_OPTIONS' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.IMPALAD_ARGS' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.SENTRY_CONFIG' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.STATESTORED_ARGS' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.CLUSTER_SIZE' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@29 PS5, Line 29: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite, \ flake8: F401 'tests.common.custom_cluster_test_suite.DEFAULT_CLUSTER_SIZE' imported but unused http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@30 PS5, Line 30: I flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@38 PS5, Line 38: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@38 PS5, Line 38: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@39 PS5, Line 39: class TestProviderFails(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@53 PS5, Line 53: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@54 PS5, Line 54: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@55 PS5, Line 55: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@58 PS5, Line 58: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@59 PS5, Line 59: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@60 PS5, Line 60: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@66 PS5, Line 66: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@67 PS5, Line 67: G flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/12901/5/tests/authorization/test_provider.py@68 PS5, Line 68: ) flake8: E124 closing bracket does not match visual indentation -- To view, visit http://gerrit.cloudera.org:8080/12901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19 Gerrit-Change-Number: 12901 Gerrit-PatchSet: 5 Gerrit-Owner: radford nguyen <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: radford nguyen <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2019 11:36:34 +0000 Gerrit-HasComments: Yes
