Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12901 )

Change subject: IMPALA-8309: add user authorization_provider flag
......................................................................


Patch Set 6:

(17 comments)

http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py
File tests/authorization/test_provider.py:

http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.CATALOGD_ARGS' imported 
but unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.IMPALA_LOG_DIR' imported 
but unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.DEFAULT_QUERY_OPTIONS' 
imported but unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.IMPALAD_ARGS' imported but 
unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.SENTRY_CONFIG' imported 
but unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.STATESTORED_ARGS' imported 
but unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.CLUSTER_SIZE' imported but 
unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@25
PS6, Line 25: from tests.common.custom_cluster_test_suite import 
CustomClusterTestSuite, \
flake8: F401 'tests.common.custom_cluster_test_suite.DEFAULT_CLUSTER_SIZE' 
imported but unused


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@26
PS6, Line 26: I
flake8: E126 continuation line over-indented for hanging indent


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@35
PS6, Line 35: class TestProviderFails(CustomClusterTestSuite):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@51
PS6, Line 51: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@52
PS6, Line 52: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@53
PS6, Line 53: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@56
PS6, Line 56: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@57
PS6, Line 57: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@58
PS6, Line 58: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/12901/6/tests/authorization/test_provider.py@63
PS6, Line 63: \
flake8: E502 the backslash is redundant between brackets



--
To view, visit http://gerrit.cloudera.org:8080/12901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19
Gerrit-Change-Number: 12901
Gerrit-PatchSet: 6
Gerrit-Owner: radford nguyen <[email protected]>
Gerrit-Reviewer: Austin Nobis <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: radford nguyen <[email protected]>
Gerrit-Comment-Date: Wed, 17 Apr 2019 11:43:22 +0000
Gerrit-HasComments: Yes

Reply via email to