Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@724 PS1, Line 724: assertEquals(1, : eventsProcessor_.getMetrics() : .getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount() : - numFilteredEvents); nit: assertEquals(numFilteredevents +1 , ..getCount() ? I think that is more readable. -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Apr 2019 19:00:10 +0000 Gerrit-HasComments: Yes
