Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 )
Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13056/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@724 PS1, Line 724: assertEquals(1, : eventsProcessor_.getMetrics() : .getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount() : - numFilteredEvents); > nit: assertEquals(numFilteredevents +1 , ..getCount() ? +1 to above suggestion. -- To view, visit http://gerrit.cloudera.org:8080/13056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ca10f82d183fd2821014e30b109b9f4474db4 Gerrit-Change-Number: 13056 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2019 19:03:47 +0000 Gerrit-HasComments: Yes
