Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 )
Change subject: IMPALA-8444: Fix performance regression when building privilege name ...................................................................... Patch Set 2: (2 comments) Couple of minor comments, lgtm otherwise. http://gerrit.cloudera.org:8080/#/c/13095/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13095/3//COMMIT_MSG@38 PS3, Line 38: operation to run in serial in a highly concurrent workload. This has a : trade off of stale authorization metadata, which may be acceptable to : get a better performance. How did you test this? I think this codepath is sensitive in the sense that most prod users run with sentry turned on and any ConccurentModificationException in prod workloads might be a disaster. Probably run a concurrency stress test of some sorts with sentry turned on? http://gerrit.cloudera.org:8080/#/c/13095/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java: http://gerrit.cloudera.org:8080/#/c/13095/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryAuthorizationPolicy.java@90 PS3, Line 90: getPrivilegeNames Is there a way to avoid a copy to a HashSet()? Not sure what that is buying us. -- To view, visit http://gerrit.cloudera.org:8080/13095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942d9b55f07c8972f69e532567d9b7d80fceb6e5 Gerrit-Change-Number: 13095 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2019 18:21:04 +0000 Gerrit-HasComments: Yes
